Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(f2v): migrate Files #39808

Merged
merged 21 commits into from
Aug 17, 2023
Merged

feat(f2v): migrate Files #39808

merged 21 commits into from
Aug 17, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 11, 2023

core/Controller/PreviewController.php Fixed Show fixed Hide fixed
core/Controller/PreviewController.php Fixed Show fixed Hide fixed
core/Controller/PreviewController.php Fixed Show fixed Hide fixed
core/Controller/PreviewController.php Fixed Show fixed Hide fixed
core/Controller/PreviewController.php Fixed Show fixed Hide fixed
core/Controller/PreviewController.php Fixed Show fixed Hide fixed
@skjnldsv skjnldsv force-pushed the feat/f2v/files branch 2 times, most recently from 912abce to 0036bd2 Compare August 16, 2023 10:52
@skjnldsv skjnldsv force-pushed the feat/f2v/files branch 3 times, most recently from b6e1994 to a945614 Compare August 16, 2023 15:01
@skjnldsv skjnldsv requested review from a team, susnux, artonge, Pytal and ShGKme and removed request for a team August 16, 2023 15:02
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 16, 2023
@skjnldsv skjnldsv mentioned this pull request Aug 16, 2023
26 tasks
@skjnldsv skjnldsv force-pushed the feat/f2v/files branch 2 times, most recently from fbd6626 to 36c4062 Compare August 16, 2023 15:34
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
Signed-off-by: John Molakvoæ <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2023
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📁🖖✨

$response->setContentSecurityPolicy($policy);

$this->provideInitialState($dir, $openfile);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv any reason for this change? It opens files whenever fileid is set, instead of only when openfile is set.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't recall. But you fixed it in the meantime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment