-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New OCS endpoint to list text processing tasks #39680
Conversation
2291fd1
to
8ee178b
Compare
What's been done:
@juliushaertl So it's only possible to list tasks by app while being authenticated. This is to prevent anonymous users to be able to list all tasks that were created by other anonymous users. Any problem with that in the Text integration? |
Fine with me as the MVP. I'd then limit the text integration to logged in users only for now. |
…tifier Signed-off-by: Julien Veyssier <[email protected]>
add a textprocessing_tasks index convert anotations to method attributes refactor TP manager add mapper methods Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
b8321ef
to
e9e7db9
Compare
Rebased on master, bumped server version to 28.0.0.2 to trigger the migration step. All good IMO. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, tested and works for my use case. 👍
Psalm is still not happy though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
please make sure to fix psalm, though
Signed-off-by: Julien Veyssier <[email protected]>
2609d8f
to
f154fe7
Compare
Failing drone acceptance test is unrelated, also there on master https://drone.nextcloud.com/nextcloud/server/38240/57/4 |
@julien-nc @marcelklehr Is there already documentation for the text processing to extend on? |
Not triggering the backport yet, but I have it on my list of requirements for 27.1 |
Yes, text processing docs have already been merged, should be easy to extend for this :) I've also created #39738 :) |
refs nextcloud/text#4613
This adds a
/tasks/app/{appId}
endpoint to get a list of tasks for the current user, for a specific app and optionally with a specific identifier.While playing with the API, I discovered that it's impossible to schedule a task while not being authenticated (mostly because of a NotNull Db constraint on the user_id column). But all the endpoints are public. Maybe we should sort this out first.
TODO