-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CardDAV): set owner-principal, displayname properties for SAB #39525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
bug
3. to review
Waiting for reviews
feature: carddav
Related to CardDAV internals
labels
Jul 21, 2023
/backport to stable27 |
miaulalala
force-pushed
the
fix/set-owner-principal-for-SAB
branch
from
July 21, 2023 10:35
69e38c2
to
1498447
Compare
ChristophWurst
approved these changes
Jul 21, 2023
tcitworld
reviewed
Jul 21, 2023
JohannesGGE
approved these changes
Jul 21, 2023
tcitworld
requested changes
Jul 24, 2023
|
miaulalala
force-pushed
the
fix/set-owner-principal-for-SAB
branch
from
July 25, 2023 14:50
fb883bd
to
e7a11d0
Compare
tcitworld
approved these changes
Jul 25, 2023
miaulalala
force-pushed
the
fix/set-owner-principal-for-SAB
branch
from
July 26, 2023 16:03
e7a11d0
to
1b77b03
Compare
JohannesGGE
force-pushed
the
fix/set-owner-principal-for-SAB
branch
from
August 8, 2023 19:08
1b77b03
to
30a9303
Compare
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/set-owner-principal-for-SAB
branch
from
August 16, 2023 07:11
30a9303
to
6bd7891
Compare
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found in #38397
Summary
The SAB has no owner principal even though it is a "shared" address book - the system user shares it will all users automatically.
Checklist