Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CardDAV): set owner-principal, displayname properties for SAB #39525

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Jul 21, 2023

Found in #38397

Summary

The SAB has no owner principal even though it is a "shared" address book - the system user shares it will all users automatically.

Checklist

@miaulalala miaulalala added bug 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels Jul 21, 2023
@miaulalala miaulalala added this to the Nextcloud 28 milestone Jul 21, 2023
@miaulalala miaulalala self-assigned this Jul 21, 2023
@miaulalala
Copy link
Contributor Author

/backport to stable27

@tcitworld
Copy link
Member

1) OCA\DAV\Tests\unit\CardDAV\AddressBookTest::testPropPatchNotShared
Expectation failed for method name is "updateAddressBook" when invoked at least 1 times.
Expected invocation at least 1 times but it occurred 0 time(s).

@miaulalala miaulalala force-pushed the fix/set-owner-principal-for-SAB branch from fb883bd to e7a11d0 Compare July 25, 2023 14:50
@miaulalala miaulalala force-pushed the fix/set-owner-principal-for-SAB branch from e7a11d0 to 1b77b03 Compare July 26, 2023 16:03
@tcitworld tcitworld disabled auto-merge July 26, 2023 20:03
@tcitworld tcitworld enabled auto-merge July 26, 2023 20:03
@JohannesGGE JohannesGGE force-pushed the fix/set-owner-principal-for-SAB branch from 1b77b03 to 30a9303 Compare August 8, 2023 19:08
@miaulalala miaulalala force-pushed the fix/set-owner-principal-for-SAB branch from 30a9303 to 6bd7891 Compare August 16, 2023 07:11
@tcitworld tcitworld merged commit 6d0dabe into master Aug 16, 2023
38 checks passed
@tcitworld tcitworld deleted the fix/set-owner-principal-for-SAB branch August 16, 2023 08:17
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug feature: carddav Related to CardDAV internals
Projects
Development

Successfully merging this pull request may close these issues.

4 participants