Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib/private/App #39299

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Refactor lib/private/App #39299

merged 4 commits into from
Feb 23, 2024

Commits on Feb 23, 2024

  1. Refactor lib/private/App 

    Signed-off-by: Hamid Dehnavi <[email protected]>
    @shdehnavi @skjnldsv
    shdehnavi authored and skjnldsv committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    84749d5 View commit details
    Browse the repository at this point in the history

  2. Fix code style 

    Signed-off-by: Hamid Dehnavi <[email protected]>
    @shdehnavi @skjnldsv
    shdehnavi authored and skjnldsv committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7a8d79b View commit details
    Browse the repository at this point in the history

  3. Make adjustments based on the psalm review 

    Signed-off-by: Hamid Dehnavi <[email protected]>
Co-authored-by: Julius Härtl <[email protected]>
Signed-off-by: Hamid Dehnavi <[email protected]>
    @shdehnavi @juliushaertl @skjnldsv
    2 people authored and skjnldsv committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b6ef67e View commit details
    Browse the repository at this point in the history

  4. Fix psalm errors 

    Signed-off-by: Hamid Dehnavi <[email protected]>
    @shdehnavi @skjnldsv
    shdehnavi authored and skjnldsv committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    cf17db2 View commit details
    Browse the repository at this point in the history