Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(richdocuments): Mark some parameters of richdocuments WopiMapper as sensitive #39040

Closed

Conversation

nickvergessen
Copy link
Member

Found in our own logs

Checklist

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jun 28, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Jun 28, 2023
@nickvergessen nickvergessen self-assigned this Jun 28, 2023
@@ -186,6 +187,10 @@
'preSetPassphrase',
'setPassphrase',
],
WopiMapper::class => [

Check failure

Code scanning / Psalm

UndefinedClass

Class, interface or enum named OCA\Richdocuments\Db\WopiMapper does not exist
@rullzer
Copy link
Member

rullzer commented Jun 29, 2023

I do get the quick fix. However for future proofing this (and quicker updates). It would be great if there is a way for apps to register their own sensitive parameters. That way it would scale better and you don't have to wait for a server update each time.

@blizzz
Copy link
Member

blizzz commented Jun 29, 2023

I do get the quick fix. However for future proofing this (and quicker updates). It would be great if there is a way for apps to register their own sensitive parameters. That way it would scale better and you don't have to wait for a server update each time.

We have that: https://github.com/nextcloud/server/blob/master/lib/public/AppFramework/Bootstrap/IRegistrationContext.php#L352

@nickvergessen
Copy link
Member Author

I do get the quick fix. However for future proofing this (and quicker updates). It would be great if there is a way for apps to register their own sensitive parameters. That way it would scale better and you don't have to wait for a server update each time.

Well once PHP 8.2 is the minimum, the correct way is using the native PHP attribute (which I added in nextcloud/richdocuments#3042 )

I was also not aware of the IRegisterContext function, so yeah will use that one instead.

@nickvergessen nickvergessen deleted the bugfix/noid/sensitive-parameters-of-wopi-mapper branch June 29, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants