Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adjust editorconfig for package.json and package-lock.json #38927

Merged
merged 1 commit into from
Jun 21, 2023
Merged

chore: Adjust editorconfig for package.json and package-lock.json #38927

merged 1 commit into from
Jun 21, 2023

Conversation

nickvergessen
Copy link
Member

  • Defactor standard in the npm universe and across half the apps and server
  • but the other half was following the initial rule of 4space tabs

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Jun 21, 2023
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Jun 21, 2023
@nickvergessen nickvergessen self-assigned this Jun 21, 2023
@ShGKme ShGKme requested a review from skjnldsv June 21, 2023 13:12
@blizzz
Copy link
Member

blizzz commented Jun 21, 2023

:shiver:

skjnldsv
skjnldsv approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@skjnldsv skjnldsv merged commit a17d019 into master Jun 21, 2023
@skjnldsv skjnldsv deleted the bugfix/noid/package.json-editorconfig branch June 21, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @blizzz @skjnldsv @ShGKme