Better update channel selector design #38922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jerome-Herbinet
added
design
@jancborchardt it's done and looking fine IMO : |
szaimen
reviewed
Jun 23, 2023
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-better-update-channel-selector-design
branch
from
9c45aff
to
bf43069
Compare
Signed-off-by: Jérôme Herbinet <[email protected]> npm run build Signed-off-by: Jérôme Herbinet <[email protected]> Better update channel selector design Signed-off-by: Jérôme Herbinet <[email protected]> npm run build Signed-off-by: Jérôme Herbinet <[email protected]> Following @jancborchardt suggestion Signed-off-by: Jérôme Herbinet <[email protected]> npm run build Signed-off-by: Jérôme Herbinet <[email protected]> Co-Authored-By: Simon L. <[email protected]>
Jerome-Herbinet
force-pushed
the
Jerome-Herbinet-better-update-channel-selector-design
branch
from
bf43069
to
a1aed1d
Compare
|
@szaimen I let you check if everything is OK for you. |
szaimen
approved these changes
Jun 23, 2023
|
@Jerome-Herbinet can you resolve the conflicts? |
susnux
approved these changes
Aug 16, 2023
4 tasks
|
See respawn #39927 |
susnux
deleted the
Jerome-Herbinet-better-update-channel-selector-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Checklist