Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix(core): Do not invert app menu text color #38897

Merged
merged 2 commits into from
Jun 20, 2023
Merged

[stable27] fix(core): Do not invert app menu text color #38897

merged 2 commits into from
Jun 20, 2023

Conversation

Hephi2
Copy link
Contributor

@Hephi2 Hephi2 commented Jun 19, 2023 •
edited
Loading

Fixes #38759
Backport of #38776

@Hephi2 Hephi2 requested a review from mejo- June 19, 2023 10:57
@Hephi2 Hephi2 changed the title fix(core): Do not invert app menu text color [stable27] fix(core): Do not invert app menu text color Jun 19, 2023
@mejo- mejo- force-pushed the fix/inverted-text-color-stable27 branch from d78d695 to aaca0cd Compare June 19, 2023 13:57
@mejo-
Copy link
Member

mejo- commented Jun 19, 2023

Cypress test failures seem unrelated. The last merge to stable27 also failed to run any Cypress e2e tests: https://github.com/nextcloud/server/actions/runs/5311915284/jobs/9615820016

@mejo-
Copy link
Member

mejo- commented Jun 19, 2023

I have no idea why the psalm test fails. Apparently it didn't fail on former stable27 PRs, but this PR doesn't touch anything related 🤔

szaimen
szaimen requested changes Jun 19, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rdparty should not get updated here

@Hephi2 Hephi2 force-pushed the fix/inverted-text-color-stable27 branch from aaca0cd to 2ba9773 Compare June 20, 2023 07:14
@juliushaertl juliushaertl added this to the Nextcloud 27.0.1 milestone Jun 20, 2023
@juliushaertl
Copy link
Member

@Hephi2 Can you check #38897 (comment) ? :)

@Hephi2 Hephi2 force-pushed the fix/inverted-text-color-stable27 branch from 2ba9773 to 76f35d0 Compare June 20, 2023 08:44
susnux and others added 2 commits June 20, 2023 11:10
@susnux @Hephi2
fix(core): Do not invert app menu text color
cdea2d0 
* Also fixes other cypress test
* Build assets

Signed-off-by: Philipp Hempel <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@Hephi2
chore(assets): Recompile assets
7fb287c 
Signed-off-by: Philipp Hempel <[email protected]>
@Hephi2 Hephi2 force-pushed the fix/inverted-text-color-stable27 branch from 9260bce to 7fb287c Compare June 20, 2023 09:15
@Hephi2 Hephi2 requested a review from szaimen June 20, 2023 09:16
szaimen
szaimen approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport looks good

@Hephi2
Copy link
Contributor Author

Hephi2 commented Jun 20, 2023

/backport cdea2d0 to stable26

@mejo- mejo- merged commit 870e599 into stable27 Jun 20, 2023
37 checks passed
@mejo- mejo- deleted the fix/inverted-text-color-stable27 branch June 20, 2023 11:17
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 20, 2023
Merged
@blizzz blizzz mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@szaimen szaimen szaimen approved these changes

Assignees
No one assigned
Labels
2. developing Work in progress bug feature: theming
Projects
None yet
Milestone
Nextcloud 27.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@Hephi2 @mejo- @juliushaertl @szaimen @susnux