Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't required since tag in OCP for inherited docs #38810

Closed
wants to merge 1 commit into from
Closed

Don't required since tag in OCP for inherited docs #38810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build/psalm/OcpSinceChecker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ private static function checkClassComment(ClassLike $stmt, FileSource $statement
return;
}

if (!isset($parsedDocblock->tags['since'])) {
if (!isset($parsedDocblock->tags['since']) && !isset($parsedDocblock->tags['inheritdoc']) && !isset($parsedDocblock->tags['inheritDoc'])) {
IssueBuffer::maybeAdd(
new InvalidDocblock(
'@since is required for classes/interfaces in OCP.',
Expand Down Expand Up @@ -103,7 +103,7 @@ private static function checkMethodComment(Stmt $stmt, FileSource $statementsSou
return;
}

if (!isset($parsedDocblock->tags['since'])) {
if (!isset($parsedDocblock->tags['since']) && !isset($parsedDocblock->tags['inheritdoc']) && !isset($parsedDocblock->tags['inheritDoc'])) {
IssueBuffer::maybeAdd(
new InvalidDocblock(
'@since is required for methods in OCP.',
Expand Down