Uses PHP8's constructor property promotion in core/Command and / #38775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
juliusknorr,
come-nc,
a team,
ArtificialOwl and
nfebe
and removed request for
a team
come-nc
requested changes
Jun 13, 2023
artonge
force-pushed
the
constructor_property_promotion_in_core_command_part9
branch
from
4c47df0
to
ff23cb5
Compare
fsamapoor
pushed a commit
to fsamapoor/server
that referenced
this pull request
Jun 20, 2023
Based on: nextcloud#38775 (comment) Signed-off-by: Faraz Samapoor <[email protected]>
artonge
approved these changes
Jun 20, 2023
come-nc
requested changes
Jun 20, 2023
artonge
pushed a commit
to fsamapoor/server
that referenced
this pull request
Jun 20, 2023
Based on: nextcloud#38775 (comment) Signed-off-by: Faraz Samapoor <[email protected]>
artonge
force-pushed
the
constructor_property_promotion_in_core_command_part9
branch
from
7960f14
to
ee5a0b0
Compare
artonge
pushed a commit
to fsamapoor/server
that referenced
this pull request
Jun 21, 2023
Based on: nextcloud#38775 (comment) Signed-off-by: Faraz Samapoor <[email protected]>
artonge
force-pushed
the
constructor_property_promotion_in_core_command_part9
branch
from
ee5a0b0
to
4d5159c
Compare
artonge
requested changes
Jun 21, 2023
There was a problem hiding this comment.
There was 1 error:
- Core\Command\TwoFactorAuth\CleanupTest::testCleanup
ArgumentCountError: Too few arguments to function OC\Core\Command\TwoFactorAuth\Cleanup::__construct(), 1 passed in /drone/src/tests/Core/Command/TwoFactorAuth/CleanupTest.php on line 47 and exactly 2 expected/drone/src/core/Command/TwoFactorAuth/Cleanup.php:36
/drone/src/tests/Core/Command/TwoFactorAuth/CleanupTest.php:47
in core/Command and /TwoFactorAuth classes. Signed-off-by: Faraz Samapoor <[email protected]>
Based on: nextcloud#38775 (comment) Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]> Signed-off-by: Faraz Samapoor <[email protected]>
Signed-off-by: Faraz Samapoor <[email protected]>
artonge
force-pushed
the
constructor_property_promotion_in_core_command_part9
branch
from
5cbfe2b
to
fd0e2f7
Compare
artonge
approved these changes
Jun 24, 2023
come-nc
approved these changes
Jun 26, 2023
fsamapoor
deleted the
constructor_property_promotion_in_core_command_part9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #38636, #38637, and #38638 PRs, I have made the required adjustments to the
/core/Command/namespace as well.I figured I should split the changes into multiple PRs to make reviewing the changes easier.
This PR refactors
/core/Commandand/core/Command/TwoFactorAuthclasses by using PHP8's constructor property promotion to remove redundant lines and make the code cleaner.