Fix default redirect on successful WebAuthn login #35604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Richard Steinmetz <[email protected]>
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
st3iny
added
3. to review
|
This might be an old bug. Before #34662 we'd still redirect to the default page. |
come-nc
approved these changes
Dec 5, 2022
|
CI failure unrelated |
Ahh, that would explain why it was broken but nobody noticed until recently. |
|
The backport to stable25 failed. Please do this backport manually. |
|
The backport to stable24 failed. Please do this backport manually. |
|
The backport to stable23 failed. Please do this backport manually. |
|
/backport to stable25 |
|
This was only a problem in master so no need for backports |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick search didn't show a related ticket but there might be some.
Summary
A user is redirected to
/falseafter logging in succesfully when no redirect url parameter is specified. I added a default url as a fallback.Before
The user is redirected to the page specified via the
redirect_urlparameter. If it isn't set, the user is redirected to/false.After
The user is redirected to the page specified via the
redirect_urlparameter. If it isn't set, the user is redirected to the configured default page.TODO
Checklist