Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Creating new shares doesn't use default admin sharing permissions #42835

Closed
skjnldsv opened this issue Jan 16, 2024 · 1 comment · Fixed by #43024
Closed

[Bug]: Creating new shares doesn't use default admin sharing permissions #42835

skjnldsv opened this issue Jan 16, 2024 · 1 comment · Fixed by #43024
Assignees

Comments

@skjnldsv
Copy link
Member

skjnldsv commented Jan 16, 2024

Bug description

Since Nextcloud 27, when you create a new share, the FULL permissions 31 gets used, unless you specifically changes the custom permissions (which then, the default are also NOT used in the pre-checked checkboxes)

Steps to reproduce

  1. Changes default permissions in admin settings
    image
  2. Create a user share
    image

Expected behavior

The new share is created with the default permissions and not 31

Additional infos

Issue seems to come from the default permissions set being used here:

if (this.isNewShare) {
if (this.isPublicShare) {
this.sharingPermission = BUNDLED_PERMISSIONS.READ_ONLY.toString()
} else {
this.sharingPermission = BUNDLED_PERMISSIONS.ALL.toString()
}
} else {

Historically, we used to sen the permissions as null to the Share OCS API and the backend would use the default permissions. Now it's always sent as 31 when untouched by the user.

@skjnldsv skjnldsv added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 1. to develop Accepted and waiting to be taken care of 27-feedback feature: sharing regression high and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jan 16, 2024
@szaimen
Copy link
Contributor

szaimen commented Jan 16, 2024

cc @Fenn-CS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants