-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITV]: Make sure that contrasts on interactive elements between normal state and focused state have to be 3:1 #40711
Comments
Maybe related, but we also need to change some other colors for accessibility (text contrast): So maybe this already fixes the problem? |
Hm, this is a really good question.
@susnux It actually does help, but the contrast requirement is not met by a pretty big margin so it unfortunately doesn't fix the issue fully :/ Ideas that are coming to mind:
Recording.2023-10-25.144840.mp4
Recording.2023-10-25.142226.mp4Would any of these work @JuliaKirschenheuter ? Important to note that nothing else should shift positions when this border appears (usually there is a slight change in the position of the text when there is a border added, which is not good) |
Using a thicker border seems nice and that is also what some others seem to do. I’d say that’s the preferred solution which looks better than the extra border – which we already use for focus feedback but is quite present. |
I agree with Jan the thicker border looks quite good and should not be a problem as the label within the border already requires some margin on top -> no resizing of the element when the border thickened. |
Hi @marcoambrosini, @nimishavijay, Thanks for your suggestions! Thank you all! |
For reference this is about: |
closing issue, done |
This is accessibility issue.
For now the contrast of components between normal state and focused state is in most cases 2:1. It have to be min. 3:1.
Examples: grey(
--color-border-maxcontrast
) <-> blue (--color-primary-element
)@jancborchardt @nimishavijay what could we do? Would it be a solution to increase color of
--color-primary-element
?The text was updated successfully, but these errors were encountered: