From 4a85113cac921957c9184461b663a725c4cce800 Mon Sep 17 00:00:00 2001 From: "Grigorii K. Shartsev" Date: Thu, 19 Oct 2023 13:53:38 +0200 Subject: [PATCH 1/7] fix(settings): remove empty aria-describedby Empty string `''` is still rendered and is not a valid ID. Signed-off-by: Grigorii K. Shartsev --- .../src/components/PersonalInfo/EmailSection/Email.vue | 2 +- .../PersonalInfo/shared/AccountPropertySection.vue | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/apps/settings/src/components/PersonalInfo/EmailSection/Email.vue b/apps/settings/src/components/PersonalInfo/EmailSection/Email.vue index 7b5d4c11028b7..9edf5a8b0df24 100644 --- a/apps/settings/src/components/PersonalInfo/EmailSection/Email.vue +++ b/apps/settings/src/components/PersonalInfo/EmailSection/Email.vue @@ -29,7 +29,7 @@ autocomplete="email" :placeholder="inputPlaceholder" :value="email" - :aria-describedby="helperText ? `${inputId}-helper-text` : ''" + :aria-describedby="helperText ? `${inputId}-helper-text` : undefined" autocapitalize="none" spellcheck="false" @input="onEmailChange"> diff --git a/apps/settings/src/components/PersonalInfo/shared/AccountPropertySection.vue b/apps/settings/src/components/PersonalInfo/shared/AccountPropertySection.vue index 8cf92fe32ede5..c9b74eeb3f43a 100644 --- a/apps/settings/src/components/PersonalInfo/shared/AccountPropertySection.vue +++ b/apps/settings/src/components/PersonalInfo/shared/AccountPropertySection.vue @@ -43,17 +43,17 @@ :placeholder="placeholder" :type="type" :value="value" - :aria-describedby="helperText ? `${name}-helper-text` : ''" + :aria-describedby="helperText ? `${name}-helper-text` : undefined" autocapitalize="none" spellcheck="false" :autocomplete="autocomplete" @input="onPropertyChange">
- + - +
From 91543677613af0aac4d988ea0a99899b1d5039a6 Mon Sep 17 00:00:00 2001 From: "Grigorii K. Shartsev" Date: Thu, 19 Oct 2023 14:18:50 +0200 Subject: [PATCH 2/7] fix(settings): fix ids and aria-labels in personal emails Signed-off-by: Grigorii K. Shartsev --- .../PersonalInfo/EmailSection/Email.vue | 25 ++++++++++--------- .../EmailSection/EmailSection.vue | 3 ++- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/apps/settings/src/components/PersonalInfo/EmailSection/Email.vue b/apps/settings/src/components/PersonalInfo/EmailSection/Email.vue index 9edf5a8b0df24..1fff440c50e15 100644 --- a/apps/settings/src/components/PersonalInfo/EmailSection/Email.vue +++ b/apps/settings/src/components/PersonalInfo/EmailSection/Email.vue @@ -23,13 +23,14 @@