From 1d9458b2526ee2f9c81b05ba2579c163cde52981 Mon Sep 17 00:00:00 2001 From: Ferdinand Thiessen Date: Wed, 3 May 2023 12:58:07 +0200 Subject: [PATCH] fix(core): Do not invert app menu text color * Also fixes other cypress test * Build assets Signed-off-by: Philipp Hempel Signed-off-by: Ferdinand Thiessen --- core/src/components/AppMenu.vue | 2 +- cypress/e2e/theming/admin-settings.cy.ts | 2 +- cypress/e2e/theming/user-background.cy.ts | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/core/src/components/AppMenu.vue b/core/src/components/AppMenu.vue index 9dbb9c26694c0..2c1b2d432c209 100644 --- a/core/src/components/AppMenu.vue +++ b/core/src/components/AppMenu.vue @@ -147,7 +147,6 @@ $header-icon-size: 20px; position: relative; display: flex; opacity: .7; - filter: var(--background-image-invert-if-bright); &.app-menu-entry__active { opacity: 1; @@ -188,6 +187,7 @@ $header-icon-size: 20px; height: $header-icon-size; padding: calc((100% - $header-icon-size) / 2); box-sizing: content-box; + filter: var(--background-image-invert-if-bright); } .app-menu-entry--label { diff --git a/cypress/e2e/theming/admin-settings.cy.ts b/cypress/e2e/theming/admin-settings.cy.ts index 4736ace9e4d6f..63242d64f1bd6 100644 --- a/cypress/e2e/theming/admin-settings.cy.ts +++ b/cypress/e2e/theming/admin-settings.cy.ts @@ -167,7 +167,7 @@ describe.only('Remove the default background with a bright color', function() { it('See the header being inverted', function() { cy.waitUntil(() => cy.window().then((win) => { - const firstEntry = win.document.querySelector('.app-menu-main li') + const firstEntry = win.document.querySelector('.app-menu-main li img') if (!firstEntry) { return false } diff --git a/cypress/e2e/theming/user-background.cy.ts b/cypress/e2e/theming/user-background.cy.ts index 86b66627ee63f..92617b33b5985 100644 --- a/cypress/e2e/theming/user-background.cy.ts +++ b/cypress/e2e/theming/user-background.cy.ts @@ -162,7 +162,7 @@ describe('User select a bright custom color and remove background', function() { it('See the header being inverted', function() { cy.waitUntil(() => cy.window().then((win) => { - const firstEntry = win.document.querySelector('.app-menu-main li') + const firstEntry = win.document.querySelector('.app-menu-main li img') if (!firstEntry) { return false }