feat: startPresentation URL parameter
#4209
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
changed the title
startPresentation URL parameter
juliusknorr
reviewed
Nov 7, 2024
src/helpers/url.js
Outdated
| @@ -45,6 +45,7 @@ const getWopiUrl = ({ fileId, title, readOnly, closeButton, revisionHistory, tar | |||
| + (revisionHistory ? '&revisionhistory=1' : '') | |||
| + (readOnly ? '&permission=readonly' : '') | |||
| + (target ? '&target=' + encodeURIComponent(target) : '') | |||
| + (Config.get('startPresentation') ? '&startPresentation=1' : '') | |||
There was a problem hiding this comment.
I think we should read into a variable once at page load and make sure to reset it to false if it was used once
There was a problem hiding this comment.
Once the page is refreshed (which, in its current state, it has to be in order to exit presentation mode) then the initial state will reset and startPresentation will not be enabled unless you again append it to the URL. I'm assuming once I implement a way to close the presentation mode this way, then it would be relevant?
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
feat/start-presentation-parameter
branch
from
0dfd12e
to
99fca49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist