fix(headers): only add Cross-Origin-Opener-Policy and Cross-Origin-Embedder-Policy on richdocuments #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bedder-Policy on richdocuments Otherwise it's being added to absolutely all requests, creating issues in other apps Closes #4103 Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
requested review from
juliusknorr,
a team and
grnd-alt
and removed request for
a team
juliusknorr
reviewed
Nov 7, 2024
| @@ -24,7 +25,7 @@ public function handle(Event $event): void { | |||
| return; | |||
| } | |||
|
|
|||
| if ($this->capabilitiesService->hasWASMSupport()) { | |||
| if ($this->capabilitiesService->hasWASMSupport() && $event->getResponse()->getApp() === Application::APPNAME) { | |||
There was a problem hiding this comment.
As far as I remember this will not work as we require the headers to be set e.g. on the files app as it is the one that iframes Collabora directly.
@caolanm Since you worked on that, can you provide some steps how to test and verify that the wasm support still fully works with that change?
There was a problem hiding this comment.
If not, would it be acceptable to hardcode 'files' (and probably 'files_sharing') as well here?
There was a problem hiding this comment.
Depends, in theory collabora could be loaded by any app, e.g. talk when using the viewer to show a file shared to a conversation.
There was a problem hiding this comment.
Though it is arguable what benefit the wasm experimental feature has there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Otherwise it's being added to absolutely all requests, creating issues in other apps.
However, since I don't know how to test this and why these headers are required, I'm not sure if this still works for public sharing pages for instance.
Ref. #3258 (comment)
TODO
Checklist