fix(sharing): Don't ask for guest name on view-only share #4048
+71
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
force-pushed
the
fix/guest-name-view-only
branch
2 times, most recently
from
654c924
to
4ba4bdd
Compare
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
juliushaertl
approved these changes
Sep 19, 2024
juliushaertl
force-pushed
the
fix/guest-name-view-only
branch
from
4ba4bdd
to
046baa7
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
fix/guest-name-view-only
branch
from
046baa7
to
256dfa2
Compare
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't ask for a guest's username if they only have read-only permissions
Checklist