feat(sharing): use @nextcloud/sharing to detect is public share
#4043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
force-pushed
the
fix/sharing
branch
2 times, most recently
from
3285bd4
to
8f63f10
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
juliushaertl
approved these changes
Sep 17, 2024
|
Actually the cypress failures on templates seem odd as they should work as logged in users
|
|
@juliushaertl It's possible they are not yet using the correct selectors since the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes occurrences where
isPublicwas trying to read from an invisible element on the page and now use the@nextcloud/sharinglibrary which is cleaner and works now with the changes on server for 31.Checklist