Change some element selectors to fix a few Cypress tests #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
changed the title
elzody
force-pushed
the
fix/why-ci-not-green
branch
from
041e888
to
5d89d1e
Compare
juliushaertl
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Looks good, I'd say we skip the remaining failing test and add a checkbox to #3170 to bring it back once we have the server template api working for public share links
3 tasks
juliushaertl
force-pushed
the
fix/why-ci-not-green
branch
from
5d89d1e
to
f0e3745
Compare
|
Pushed a commit to skip the test |
elzody
force-pushed
the
fix/why-ci-not-green
branch
from
f0e3745
to
0291f27
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
fix/why-ci-not-green
branch
from
0291f27
to
5125ec6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some selectors changed for the files app, so we correct those here. There are other issues which still cause some tests to fail, but they are deeper issues which may not be entirely worth looking into immediately as things are still in flux in the server repo and things are changing.
Checklist