fix: use file picker component directly #3995
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
reviewed
Sep 10, 2024
|
Could you also add a cypress test for that? |
elzody
force-pushed
the
fix/3957
branch
2 times, most recently
from
409aaec
to
f761ea7
Compare
elzody
force-pushed
the
fix/3957
branch
2 times, most recently
from
546b83f
to
b49f431
Compare
Richdocuments
|
||||||||||||||||||||||||||||||||||
| Project |
Richdocuments
|
| Branch Review |
fix/3957
|
| Run status |
|
| Run duration | 02m 01s |
| Commit |
|
| Committer | Elizabeth Danzberger |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
1
|
Passing
|
11
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/settings.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Office admin settings > Error for invalid url |
Test Replay
Screenshots
|
|
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous implementation stopped working because the file picker's
containerprop expects a selector, but an element was passed instead. This PR fixes that, and uses the file picker component directly.Checklist