Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add parameter to allow converting files after filling out fields #3951

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 27, 2024

Need to review my own code again tomorrow but so far this should do the trick to help the integrations team with building nice workflows

cc @julien-nc

I should also add a test

curl -v -X POST -H 'OCS-APIRequest: 1' -u admin:admin https://nextcloud.local/ocs/v2.php/apps/richdocuments/api/v1/template/fields/fill/406\?convert\=pdf  > test2.pdf
curl -v -X POST -H 'OCS-APIRequest: 1' -u admin:admin https://nextcloud.local/ocs/v2.php/apps/richdocuments/api/v1/template/fields/fill/406\?convert\=pdf\&destination\=myfile.pdf

@julien-nc julien-nc self-requested a review September 5, 2024 13:47
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works like a charm.
Code looks good.
Nice that it now prints the document content if destination is null!
Thanks a lot 💙

@juliushaertl juliushaertl force-pushed the feat/fill-and-convert branch 2 times, most recently from 726c225 to 65ad121 Compare September 10, 2024 13:49
@juliushaertl
Copy link
Member Author

Pushed some integration tests for the endpoints

@juliushaertl juliushaertl added bug Something isn't working 4. to release Ready to release, can be waiting for the tests to finish labels Sep 10, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a thorough test, works nicely. Also nice code

@juliushaertl juliushaertl merged commit 9b10ec7 into main Sep 13, 2024
68 of 71 checks passed
@juliushaertl juliushaertl deleted the feat/fill-and-convert branch September 13, 2024 08:15
@juliushaertl
Copy link
Member Author

/backport to stable30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to release, can be waiting for the tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants