Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not set a guest name on actual users #3948

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 26, 2024

Should fix using the wrong user for filesystem access as described in nextcloud/server#40090

Before this the node was obtained from the share owner which caused issues getting the relative path later on

Debugger screenshot for my own reference:

image

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

Copy link

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine for me and solves nextcloud/server#40090 👍
Thanks!

@juliushaertl juliushaertl added 3. to review Ready to be reviewed and removed 2. developing Work in progress labels Aug 26, 2024
@juliushaertl
Copy link
Member Author

@elzody Do you remember what the intention of the change in 63aece8#diff-7a3746877ab19393cc83236c399a1a05d24b6dd96ddc1bfa2985b74108a04ca2R202 was?

@juliushaertl juliushaertl marked this pull request as ready for review August 26, 2024 11:55
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juliushaertl I can't recall, I think it was confusing logic for me and I accidentally had the wrong approach there. It makes sense now with this, and if it indeed fixes the issue, looks good from my side

@juliushaertl juliushaertl merged commit 35fc522 into main Aug 26, 2024
63 checks passed
@juliushaertl juliushaertl deleted the fix/skip-guest-name-on-users branch August 26, 2024 19:52
@juliushaertl
Copy link
Member Author

/backport to stable30

@juliushaertl
Copy link
Member Author

/backport to stable29

Copy link

backportbot bot commented Aug 26, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/3948/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ddc825dc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3948/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliushaertl
Copy link
Member Author

/backport to stable28

Copy link

backportbot bot commented Aug 26, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/3948/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ddc825dc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3948/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@juliushaertl
Copy link
Member Author

/backport to stable27

Copy link

backportbot bot commented Aug 26, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/3948/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ddc825dc

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/3948/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed backport-request bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants