Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: Show PDF even when download hidden on public share #3887

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Aug 7, 2024

Backport of #3872

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added bug Something isn't working 3. to review Ready to be reviewed javascript Pull requests that update Javascript code regression labels Aug 7, 2024
@backportbot backportbot bot added this to the Nextcloud 27 milestone Aug 7, 2024
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Copy link

cypress bot commented Aug 7, 2024



Test summary

32 1 0 0


Run details

Project Richdocuments
Status Failed
Commit 7b8c095
Started Aug 7, 2024 6:52 PM
Ended Aug 7, 2024 6:55 PM
Duration 03:22 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


Failures

cypress/e2e/integration.spec.js Failed
1 Nextcloud integration > Save as

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@elzody elzody marked this pull request as ready for review August 7, 2024 19:18
@elzody elzody merged commit 5f368a3 into stable27 Aug 8, 2024
44 of 46 checks passed
@elzody elzody deleted the backport/3872/stable27 branch August 8, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working javascript Pull requests that update Javascript code regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant