-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tests): Implement testing for new template workflow (filling templates) #3885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elzody
added
enhancement
New feature or request
2. developing
Work in progress
javascript
Pull requests that update Javascript code
tests
feature: templates
labels
Aug 6, 2024
elzody
force-pushed
the
test/template-filling
branch
from
August 6, 2024 17:41
e7b174f
to
9a1ea20
Compare
juliusknorr
requested changes
Aug 6, 2024
the release runner failure looks unrelated, but the nightly-3 failure seems related:
|
Let's wait for #3890 to see what tests actually fail on which collabora container |
elzody
force-pushed
the
test/template-filling
branch
from
August 12, 2024 12:26
268bf39
to
4b9de1d
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
test/template-filling
branch
from
August 14, 2024 20:06
4b9de1d
to
16102a2
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
3 tasks
juliusknorr
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Work in progress
enhancement
New feature or request
feature: templates
javascript
Pull requests that update Javascript code
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the existing cypress tests in
templates.spec.js
, and introduces new tests to cover the additions to the template workflow; namely filling templates.Checklist