Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add check if collabora supports template filling #3875

Merged
merged 1 commit into from
Aug 5, 2024
Merged

fix: Add check if collabora supports template filling #3875

merged 1 commit into from
Aug 5, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Aug 3, 2024 •
edited
Loading

Otherwise we always do a failing request to Collabora on older versions.

@juliushaertl juliushaertl force-pushed the fix/form-fill-capabilities-check branch from d75e82e to cfea29b Compare August 3, 2024 07:55
@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Aug 5, 2024
mejo-
mejo- approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look sensible 👌

@juliushaertl juliushaertl merged commit e17bf9e into main Aug 5, 2024
62 checks passed
@juliushaertl juliushaertl deleted the fix/form-fill-capabilities-check branch August 5, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejo- mejo- mejo- approved these changes

@elzody elzody Awaiting requested review from elzody

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliushaertl @mejo-