fix: Show PDF even when download hidden on public share #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
added
bug
juliusknorr
reviewed
Aug 5, 2024
Signed-off-by: Elizabeth Danzberger <[email protected]>
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
elzody
changed the title
juliusknorr
reviewed
Aug 6, 2024
src/public.js
Outdated
| OC.Plugins.register('OCA.Files.NewFileMenu', NewFileMenu) | ||
| } | ||
|
|
||
| if (isPdf()) { |
There was a problem hiding this comment.
I think we should only trigger this if it is actually "download hidden share" or if the files_pdfviewer app is disabled. Otherwise the regular pdf viewer should be preferred.
There was a problem hiding this comment.
If I'm understanding you correctly, it should be fixed in my recent commits -- essentially, if the download is hidden or the files_pdfviewer is not enabled, open the PDF in richdocuments. Also open in richdocuments if it's an office document. otherwise, let the viewer handle it
There was a problem hiding this comment.
Yes, just went through testing the different constellations and looks all good 👍
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
juliusknorr
approved these changes
Aug 7, 2024
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue seemed to be caused by loading
files.jsin addition topublic.js, so the logic was just moved to the newer implementation inpublic.js.TODO
Checklist