Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

richdocuments: add host_session_id parameter #3763

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

hcvcastro
Copy link
Member

  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliushaertl juliushaertl added enhancement New feature or request 2. developing Work in progress labels Jun 14, 2024
@juliushaertl
Copy link
Member

Can you provide some context on what this is used?

In addition you can already get the richdocuments version in the frontend code through the capabilities so no backend changes should be required and please also add it to

<input name="access_token" :value="formData.accessToken" type="hidden">

import { getCapabilities } from '../services/capabilities.ts'

getCapabilities().version

Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs mentioned adjustments

@hcvcastro
Copy link
Member Author

Thanks, it is mostly to implement Wopi HOST_SESSION_ID, to debugging log purposes and
to track wopi host logs for troubleshooting purposes based on a host-specific session identifier

src/document.js Outdated Show resolved Hide resolved
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still needs to also be added in

<input name="access_token" :value="formData.accessToken" type="hidden">

"This helps for the web engineers more quickly find logs
for troubleshooting purposes based on a host-specific session identifier".

Signed-off-by: Henry Castro <[email protected]>
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@juliushaertl juliushaertl merged commit e44e5dc into nextcloud:main Jul 15, 2024
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement New feature or request feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants