fix: Do not set user id for guests #3676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
|
I think this was a result of me not quite understanding all of the logic behind how guest usernames should be passed and how the user ID works there. Sorry about that, makes sense why that should not be there. |
elzody
approved these changes
May 8, 2024
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #3675
Aparently I've not catched that during testing as it only happens on file save. We should extend our integration tests for the WOPI endpoints in that regard.
@elzody Do you recall what the line tried to achieve in your recent change?
Edit: This test could have catched this however the /token endpoint is not used in the behat tests. Will see if we can extend that