Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File action to open PDFs with richdocuments when files_pdfviewer is enabled #3645

Merged
merged 1 commit into from
May 2, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented May 1, 2024

Summary

Since 28, when the files_pdfviewer app is enabled, there is no open to open a PDF using richdocuments. This PR fixes that, using the files API to register a file action. By default, when you click on the file, it will still use the files_pdfviewer when enabled.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody added bug Something isn't working 3. to review Ready to be reviewed regression labels May 1, 2024
@elzody elzody self-assigned this May 1, 2024
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on the app icon, otherwise very nice and good to get in 👍

@juliushaertl juliushaertl merged commit 0747353 into main May 2, 2024
55 checks passed
@juliushaertl juliushaertl deleted the fix/file-action-pdf branch May 2, 2024 19:10
@juliushaertl
Copy link
Member

/backport to stable29

@juliushaertl
Copy link
Member

/backport to stable28

@juliushaertl
Copy link
Member

@elzody Would be quite nice if we could follow up with a small cypress test for this to avoid further regressions

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working feedback-requested regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Edit in Nextcloud Office option for PDF files
2 participants