Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Block incompatible operations with remote tokens #3635

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

juliusknorr
Copy link
Member

With federated tokens we do not allow storage operations that would be
relative to the file path so we should block them

Signed-off-by: Julius Härtl [email protected]

  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr
Copy link
Member Author

/backport! to stable24

With federated tokens we do not allow storage operations that would be
relative to the file path so we should block them

Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr juliusknorr force-pushed the fix/limit-remote-token-relative-actions branch from 0787009 to 479c046 Compare April 30, 2024 20:51
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed backport-request labels Apr 30, 2024
Copy link
Contributor

@elzody elzody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable~

@blizzz blizzz merged commit 7038810 into main Jun 17, 2024
51 checks passed
@blizzz blizzz deleted the fix/limit-remote-token-relative-actions branch June 17, 2024 20:54
@juliusknorr
Copy link
Member Author

/backport to stable29

@juliusknorr
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants