Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open locally with files lock and wopi allow list (backport stable26) #3515

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

lpranam
Copy link
Contributor

@lpranam lpranam commented Mar 8, 2024

  • fix: Add config option to disable edit locally
  • fix: Allow to unlock through separate endpoint for edit locally

Fix #3487
Fix #3299

Summary
We add a config value for disabling but also address that unlocking the file was no longer working with a WOPI allow list. We now move this to a separate endpoint to handle any prepare steps we need to do before moving to the local editor.

In a second iteration we can further extend this to update the other views to read only or notify them through Collabora.

Configuration option to disable local editing

occ config:app:set richdocuments open_local_editor --value="no"
  • Target version: stable26

backport from #3489

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels Mar 8, 2024
@juliushaertl juliushaertl self-requested a review March 8, 2024 14:28
@lpranam lpranam closed this Mar 13, 2024
@lpranam
Copy link
Contributor Author

lpranam commented Mar 13, 2024

@juliushaertl can you please take on this? 😓

@lpranam lpranam deleted the fix/open-locally/stable26 branch March 13, 2024 02:36
@lpranam lpranam restored the fix/open-locally/stable26 branch March 19, 2024 08:48
@lpranam lpranam reopened this Mar 19, 2024
@lpranam
Copy link
Contributor Author

lpranam commented Mar 21, 2024

@juliushaertl ping :)

@juliushaertl juliushaertl self-assigned this Mar 26, 2024
@juliushaertl juliushaertl force-pushed the fix/open-locally/stable26 branch 2 times, most recently from 82200ed to 68bb63f Compare March 26, 2024 16:06
@juliushaertl juliushaertl merged commit a7ccfd9 into nextcloud:stable26 Mar 27, 2024
44 checks passed
@lpranam lpranam deleted the fix/open-locally/stable26 branch March 27, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants