Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Let wopi middleware also handle asset fetching #3403

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix: Let wopi middleware also handle asset fetching #3403

merged 2 commits into from
Jan 11, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jan 11, 2024 •
edited
Loading

  • fix: Let wopi middleware also handle asset fetching
  • chore: Move to class/method attributes for middleware checks

@juliusknorr juliusknorr added this to the Nextcloud 29 milestone Jan 11, 2024
@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed technical debt labels Jan 11, 2024
@juliusknorr juliusknorr force-pushed the bugfix/middleware-asset branch 2 times, most recently from 2bd7e4a to 19a2aa2 Compare January 11, 2024 10:38
max-nextcloud
max-nextcloud requested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either I'm confused or this would not work as intended. 😉

lib/Middleware/WOPIMiddleware.php Outdated Show resolved Hide resolved
lib/Middleware/WOPIMiddleware.php Outdated Show resolved Hide resolved
max-nextcloud
max-nextcloud approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my comments so fast... Now looks good to me.

@juliusknorr juliusknorr merged commit 745b10a into main Jan 11, 2024
58 checks passed
@juliusknorr juliusknorr deleted the bugfix/middleware-asset branch January 11, 2024 11:49
@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport 7edf59f to stable27

@juliusknorr
Copy link
Member Author

/backport 7edf59f to stable26

@juliusknorr
Copy link
Member Author

/backport 7edf59f to stable25

@juliusknorr
Copy link
Member Author

/backport 7edf59f to stable24

@juliusknorr
Copy link
Member Author

/backport 7edf59f to stable23

This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@luka-nextcloud luka-nextcloud luka-nextcloud approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@mejo- mejo- Awaiting requested review from mejo-

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working technical debt
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @luka-nextcloud @max-nextcloud