Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] fix: mention popup reappears after inserting the mention #3398

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

juliushaertl
Copy link
Member

Backport of #3356

- when COOL inserts the mention it sends 'UI_Mention'
  with 'type: selected', we don't want to send 'Action_Mention'
  for 'selected' type

Signed-off-by: Rashesh Padia <[email protected]>
Copy link
Member Author

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juliushaertl juliushaertl added bug Something isn't working 4. to release Ready to release, can be waiting for the tests to finish labels Jan 9, 2024
Copy link

cypress bot commented Jan 9, 2024

Passing run #752 ↗︎

0 31 0 0 Flakiness 0

Details:

[stable27] fix: mention popup reappears after inserting the mention
Project: Richdocuments Commit: 11d62fd622
Status: Passed Duration: 02:28 💡
Started: Jan 9, 2024 10:55 AM Ended: Jan 9, 2024 10:58 AM

Review all test suite changes for PR #3398 ↗︎

@juliushaertl juliushaertl merged commit 8c3bf24 into stable27 Jan 9, 2024
36 checks passed
@juliushaertl juliushaertl deleted the backport/3356/stable27 branch January 9, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to release, can be waiting for the tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants