fix: mention popup reappears after inserting the mention #3356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rash419
force-pushed
the
fix-mention-popup
branch
2 times, most recently
from
1d15b23
to
c1fb2fa
Compare
juliushaertl
approved these changes
Dec 15, 2023
juliushaertl
added
bug
|
/backport to stable28 |
|
/backport to stable27 |
|
@Rash419 could you rebase instead of merging for update? Otherwise the automated backports will fail |
Rash419
force-pushed
the
fix-mention-popup
branch
from
e176b16
to
5155e1c
Compare
Rash419
changed the title
- when COOL inserts the mention it sends 'UI_Mention' with 'type: selected', we don't want to send 'Action_Mention' for 'selected' type Signed-off-by: Rashesh Padia <[email protected]>
Rash419
force-pushed
the
fix-mention-popup
branch
from
5155e1c
to
ffb4483
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist