Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added new 'Error_Messages' postmessage #3217

Closed
wants to merge 1 commit into from
Closed

added new 'Error_Messages' postmessage #3217

wants to merge 1 commit into from

Conversation

Rash419
Copy link
Contributor

@Rash419 Rash419 commented Oct 10, 2023 •
edited by juliusknorr
Loading

  • so that collbora online can show a custom with nextcloud documentation link

TODO

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@Rash419 Rash419 marked this pull request as draft October 10, 2023 07:48
juliusknorr
juliusknorr reviewed Oct 10, 2023
View reviewed changes
src/document.js Outdated Show resolved Hide resolved
@Rash419
Copy link
Contributor Author

Rash419 commented Oct 10, 2023

@juliushaertl sorry if dumb question
how can I debug richdocuments ?
where does document.js code goes? If I am debugging in browser in which file does document.js goes ?

@juliusknorr
Copy link
Member

document.js is only used on some occasions, we refactored quite a bit with #3152 so that regular file openings as a logged in user only use viewer.js, where you might want to add this also in src/view/Office.vue.

All js files are bundled with webpack but when building in development mode (npm run dev) browsers development console should still be able to inspect the individual source files.

@Rash419
Copy link
Contributor Author

Rash419 commented Oct 10, 2023 •
edited
Loading

@juliushaertl is that even possible to send post message before document getting loaded ? because document doesnot get ready if websocket connection deosnot get established

@Rash419 Rash419 marked this pull request as ready for review October 10, 2023 14:11
@Rash419 Rash419 mentioned this pull request Oct 10, 2023
Merged
6 tasks
pedropintosilva
pedropintosilva previously requested changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@pedropintosilva pedropintosilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message should be localized. Probably following the same syntax as somewhere else. example: "t('richdocuments', 'Document loading failed')"

juliusknorr
juliusknorr reviewed Oct 12, 2023
View reviewed changes
src/view/Office.vue Outdated Show resolved Hide resolved
@Rash419
Copy link
Contributor Author

Rash419 commented Oct 16, 2023 •
edited
Loading

@juliushaertl
I just setup nc https://github.com/juliushaertl/nextcloud-docker-dev
I cannot open any file at all for example images, video etc

In logs I see this

master-proxy-1 | nginx.1 | nextcloud.local 192.168.21.1 - - [16/Oct/2023:13:06:59 +0000] "PROPFIND /remote.php/dav/files/admin/workshop-contributing-to-NO-CO.odp HTTP/1.1" 207 588 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36" "192.168.21.6:80"
Any suggestions how can I fix this ?

@juliusknorr
Copy link
Member

Can you double check if https://github.com/nextcloud/viewer is installed and enabled as an app?

Feel free to ask Pedro for the link to the chat we have to check this more synchronously together ;)

@Rash419
Copy link
Contributor Author

Rash419 commented Oct 17, 2023

Can you double check if https://github.com/nextcloud/viewer is installed and enabled as an app?

Feel free to ask Pedro for the link to the chat we have to check this more synchronously together ;)

Manually cloning viewer app fixes the problem

@Rash419 Rash419 force-pushed the add/new/postmsg branch 4 times, most recently from 6c08d03 to 723d1ff Compare October 17, 2023 11:15
@Rash419 @juliusknorr
added new 'Error_Messages' postmessage
1d61ac9 
- handle App_LoadingStatus Initialized
- using Error_Messages richdocuments can pass custom error msg to
  collabora with nextcloud documentation link

Signed-off-by: Rashesh Padia <[email protected]>
@juliusknorr juliusknorr added 2. developing Work in progress enhancement New feature or request labels Oct 20, 2023
@juliusknorr juliusknorr added this to the Nextcloud 28 milestone Oct 20, 2023
@juliusknorr juliusknorr mentioned this pull request Dec 29, 2023
Merged
3 tasks
@juliusknorr
Copy link
Member

I'll close this since custom error messages have been pushed to #3311

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

@pedropintosilva pedropintosilva Awaiting requested review from pedropintosilva

Assignees
No one assigned
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@Rash419 @juliusknorr @pedropintosilva