Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log invalid wopi tokens at info level instead of error #3107

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 14, 2023

This is a quite common case when inactive browser tabs are reconnecting so we should rather log at info than error.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr juliusknorr added bug Something isn't working 3. to review Ready to be reviewed labels Aug 14, 2023
@cypress
Copy link

cypress bot commented Aug 14, 2023

Passing run #511 ↗︎

0 25 0 0 Flakiness 0

Details:

fix: Log invalid wopi tokens at info level instead of error
Project: Richdocuments Commit: 9ebdab305d
Status: Passed Duration: 02:41 💡
Started: Aug 14, 2023 10:04 AM Ended: Aug 14, 2023 10:07 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@juliusknorr juliusknorr merged commit 6ff1851 into main Aug 16, 2023
41 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/wopi-error-log branch August 16, 2023 06:12
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr
Copy link
Member Author

/backport to stable26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants