Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create empty files from template if available #3059

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jul 11, 2023

Before this change empty files were always just created with a copy of the empty documents, which enforced US spell checking. With this we create a file from the present empty template files.

Fixes #3029
Fixes #2983

Steps to reproduce:

  • Change user language to german
  • Create a new empty file
  • See that the spell checking language of the new document properly adapts

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliusknorr
Copy link
Member Author

cc @gokaysatir as you pointed that out in #3029

@juliusknorr juliusknorr added 3. to review Ready to be reviewed bug Something isn't working labels Jul 11, 2023
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr
Copy link
Member Author

/backport to stable26

@cypress
Copy link

cypress bot commented Jul 11, 2023

Passing run #435 ↗︎

0 25 0 0 Flakiness 0

Details:

fix: Create empty files from template if available
Project: Richdocuments Commit: 45973ce283
Status: Passed Duration: 02:49 💡
Started: Jul 11, 2023 10:50 AM Ended: Jul 11, 2023 10:53 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr
Copy link
Member Author

Arg, merged the wrong tab 🙈 @blizzz Up for a quick retroactive review?

@thebearon
Copy link
Collaborator

@juliushaertl I assume this fix is also relevant to version 25, is it so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
Archived in project
2 participants