Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move away from deprecated ILogger and Server::query #2991

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Jun 6, 2023

Let's drop old stuff

Remaining ones need to be tackled separately: #2992

@juliusknorr juliusknorr requested review from mejo- and blizzz June 6, 2023 14:29
@juliusknorr juliusknorr added 3. to review Ready to be reviewed technical debt labels Jun 6, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me 👌

@cypress
Copy link

cypress bot commented Jun 6, 2023

Passing run #342 ↗︎

0 25 0 0 Flakiness 0

Details:

chore: Move away from deprecated ILogger and Server::query
Project: Richdocuments Commit: 29d0f44303
Status: Passed Duration: 03:32 💡
Started: Jun 6, 2023 3:36 PM Ended: Jun 6, 2023 3:40 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr merged commit ae3342a into main Jun 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the chore/deprecations branch June 7, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Ready to be reviewed technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants