Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to NcSelect and @nextcloud/vue 8 #2945

Merged
merged 5 commits into from
Dec 28, 2023
Merged

Switch to NcSelect and @nextcloud/vue 8 #2945

merged 5 commits into from
Dec 28, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented May 12, 2023 •
edited
Loading

  • Check other multiselect usages
  • Difference to the old component
    • No checkmark next to already selected entries in the list
    • Clicking an already selected item in the list doesn't remove it
  • Move dialogs to new API and vue components
  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@juliushaertl juliushaertl mentioned this pull request May 12, 2023
Merged
3 tasks
@cypress
Copy link

cypress bot commented May 12, 2023 •
edited
Loading

Passing run #486 ↗︎

0 25 0 0 Flakiness 0

Details:

enh/switch ncselect
Project: Richdocuments Commit: a57490ed25
Status: Passed Duration: 02:47 💡
Started: Jul 31, 2023 7:39 AM Ended: Jul 31, 2023 7:42 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl changed the title enh/switch ncselect Switch to NcSelect and @nextcloud/vue 8 Dec 27, 2023
@juliushaertl juliushaertl force-pushed the enh/switch-ncselect branch 4 times, most recently from fe2f023 to 01b1903 Compare December 27, 2023 13:49
@juliushaertl juliushaertl marked this pull request as ready for review December 27, 2023 13:58
luka-nextcloud
luka-nextcloud reviewed Dec 27, 2023
View reviewed changes
src/components/SettingsSelectTag.vue Outdated Show resolved Hide resolved
src/view/DocumentTargetPicker.vue Outdated Show resolved Hide resolved
@juliushaertl
fix: Move to new dialogs APIs
c6306bb 
Signed-off-by: Julius Härtl <[email protected]>
juliushaertl
juliushaertl commented Dec 28, 2023
View reviewed changes
Copy link
Member Author

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luka-nextcloud Good catches, I've pushed the changes

@juliushaertl juliushaertl merged commit 6fd77bf into main Dec 28, 2023
46 checks passed
@juliushaertl juliushaertl deleted the enh/switch-ncselect branch December 28, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud approved these changes

Assignees
No one assigned
Labels
3. to review Ready to be reviewed technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliushaertl @luka-nextcloud