Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve group multiselect behaviour with multiple and long group names #2944

Merged
merged 3 commits into from
May 12, 2023
Merged

Improve group multiselect behaviour with multiple and long group names #2944

merged 3 commits into from
May 12, 2023

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented May 11, 2023 •
edited
Loading

  • fix: Do not limit group selector in settings
  • fix: Avoid cutting off group list too early
  • fix: Filter selected groups first and properly display groups that are not fetched in the initial result response

Backportable implementation, draft for moving to the new component at #2945

Summary

Before After
Screenshot 2023-05-12 at 09 21 50 Screenshot 2023-05-12 at 09 21 53 Screenshot 2023-05-12 at 09 23 02 Screenshot 2023-05-12 at 09 21 12

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@cypress
Copy link

cypress bot commented May 11, 2023

Passing run #274 ↗︎

0 25 0 0 Flakiness 0

Details:

bugfix/2943
Project: Richdocuments Commit: f3ee2ab82c
Status: Passed Duration: 02:49 💡
Started: May 11, 2023 5:13 PM Ended: May 11, 2023 5:16 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliushaertl juliushaertl added bug Something isn't working 3. to review Ready to be reviewed labels May 12, 2023
@juliushaertl juliushaertl added this to the Nextcloud 27 milestone May 12, 2023
@juliushaertl juliushaertl changed the title bugfix/2943 Improve group multiselect behaviour with multiple and long group names May 12, 2023
@juliushaertl
Copy link
Member Author

/backport to stable26

@juliushaertl
Copy link
Member Author

/backport to stable25

datenangebot
datenangebot approved these changes May 12, 2023
View reviewed changes
Copy link

@datenangebot datenangebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks reasonable to me

@juliushaertl juliushaertl merged commit d7c80a2 into main May 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the bugfix/2943 branch May 12, 2023 09:33
This was referenced May 12, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datenangebot datenangebot datenangebot approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

Assignees
No one assigned
Labels
3. to review Ready to be reviewed bug Something isn't working
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

Settings group multiselect doesn't show full group name
2 participants
@juliushaertl @datenangebot