Move to more generic way of parsing wopi discovery #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
nextcloud-command
force-pushed
the
enh/wopi
branch
from
8d2a491
to
5492b80
Compare
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
juliusknorr
force-pushed
the
enh/wopi
branch
2 times, most recently
from
6f9402c
to
bf6b417
Compare
juliusknorr
added
enhancement
juliusknorr
force-pushed
the
enh/wopi
branch
from
bf6b417
to
09b611a
Compare
Signed-off-by: Julius Härtl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of WOPI discovery use the non-deprecated actions
This is also a first step to abandon https://github.com/nextcloud/officeonline so we don't need to maintain two different apps. Other than that for compatibility with other WOPi server we would need to:
Implement native locking if files_lock is not enabled
Do not require the capabilities endpoint to setup a server
Maybe something more
Add compatibility mode setting for enabling generic wopi compatibility with limited functionality
Relevant file locking related work: