Exclude MSOffice mime types association if OnlyOffice app is installed #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
If OnlyOffice is installed we should also merge This will allow these mimetypes to be opened with collabora via the context menu. |
juliusknorr
reviewed
Oct 17, 2022
juliusknorr
added
enhancement
|
@proxyconcept Any news on addressing the review comments? |
juliusknorr
force-pushed
the
fix-mimetypes-for-onlyoffice
branch
from
d2ff428
to
ab55363
Compare
|
I took over and implemented the suggestion and rebased. |
juliusknorr
force-pushed
the
fix-mimetypes-for-onlyoffice
branch
from
ab55363
to
5a74f44
Compare
juliusknorr
approved these changes
Sep 1, 2023
juliusknorr
added
4. to release
juliusknorr
force-pushed
the
fix-mimetypes-for-onlyoffice
branch
from
5a74f44
to
e15e4bd
Compare
Signed-off-by: Grégory Marigot <[email protected]>
juliusknorr
force-pushed
the
fix-mimetypes-for-onlyoffice
branch
from
e15e4bd
to
ed7bb01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Grégory Marigot [email protected]
Summary
The Nextcloud Office app configure the association with all possible office documents mime types.
But if we also have the OnlyOffice app, it's not possible to open any document with it...
Collabora and OnlyOffice are both great and it's a common case to want to install both: Collabora for OpenOffice documents and OnlyOffice for MSOffice documents.
This patch is a workaround specific for this case (and because it's not possible to wait for nextcloud/viewer#2393) : the Nextcloud Office app check if the OnlyOffice app is not installed before adding all the MSOffice mime types.
Checklist