Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office: Fonts improvements: Previews, popular from Google Fonts, checking with LO desktop fonts, deduplicating Noto Sans & Serif variants #3139

Closed
12 of 13 tasks
juliusknorr opened this issue Aug 24, 2023 · 11 comments · Fixed by #3304

Comments

@juliusknorr
Copy link
Member

juliusknorr commented Aug 24, 2023

  • Font preview ongoing in COOL
  • Ship popular fonts
    • Clarify licenses if we can ship it, need to attribute (and how)
    • Test if variable fonts work as expected (e.g. RobotoMono-VariableFont_wght.ttf)
    • Pick font files to ship depending on if variable sizing is working to not increase the richdocuments bundle size too much
    • Implementation Feature/fonts improvement #3304 @luka-nextcloud
      • Font files get shipped as part of richdocuments in an extra assets/fonts/ directory
      • New fonts shall be copied from the assets/fonts folder and added through the existing FontService method
      • Add a repair job to add new fonts once to the installation (repair step version check example)
      • Add an occ command to install shipped fonts again if manually removed as the admin
      • Cypress test that ensures the fonts are listed in the admin settings
  • Possible follow up: Deduplicate/group fonts in the UI -> Collabora
@juliusknorr
Copy link
Member Author

We could also just add the popular fonts to richdocuments and if we improve the remote configuration #2169

@jancborchardt Would it make sense to already come up with a list of popular fonts that we want to ship? The ones popular on https://fonts.google.com/?preview.size=30&preview.layout=row&sort=popularity have a lot of overlap in similar style so maybe you could come up with some preselection of nice ones to ship?

@juliusknorr
Copy link
Member Author

@jancborchardt ping for a possible list of fonts. We could start shipping those with richdocuments and then try to improve the auto setup to pick up fonts automatically from there.

@jancborchardt
Copy link
Member

jancborchardt commented Sep 18, 2023

@jospoortvliet

This comment was marked as off-topic.

@juliusknorr

This comment was marked as off-topic.

@juliusknorr

This comment was marked as off-topic.

@juliusknorr

This comment was marked as off-topic.

@luka-nextcloud
Copy link
Contributor

@juliushaertl

Font files get shipped as part of richdocuments in an extra assets/fonts/ directory

  • Where can I get font files?
  • assets folder will place on root (same level as src, lib, appinfo, ..), right?

@juliusknorr
Copy link
Member Author

juliusknorr commented Nov 14, 2023

You can download them from the list in #3139 (comment), but feel free to just use one for testing for now. I already have a full directory with all of them that I can just push to the pull request then.

The assets I'd just put in the root, yes.

@jospoortvliet

This comment was marked as off-topic.

@juliusknorr

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants