Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify users on mentions in document comments #1380

Open
4 of 6 tasks
thkoch2001 opened this issue Feb 24, 2021 · 12 comments · Fixed by #2576
Open
4 of 6 tasks

Notify users on mentions in document comments #1380

thkoch2001 opened this issue Feb 24, 2021 · 12 comments · Fixed by #2576
Assignees
Labels
1. to develop Waiting for a developer enhancement New feature or request upstream: collabora online

Comments

@thkoch2001
Copy link

thkoch2001 commented Feb 24, 2021

Current status

  • Evaluate filetype/core requirements in Support mentioning of contacts in comments CollaboraOnline/online#1529
  • Implement handling of mentions in core
  • Implement some user listing mechanism on the Nextcloud side
  • Implement handling of mentions in online
  • Listen to the post message for inserted mention and emit a notifcation to the user
  • Collabora implementation to also support mentions in comments (not just the document content)

Pull requests

Initial request

Is your feature request related to a problem? Please describe.

  • As an owner of a document I want to get notified on any comment that gets added to my document in order to provide a timely answer.
  • As a commenter of a document I want to be able to mention a person in a comment and thus raise their awareness of an action or input that is needed from their side.
  • As a reader of a document I want to be able to subscribe to a document to get informed about all comments to that document.
  • As a participant in a comment thread I want to be notified of all updates to all new comments to a comment thread.
  • As a participant in a comment thread I want to be notified when the thread gets resolved.

Describe the solution you'd like
Destroy any reason to use Google Docs ever again.

Describe alternatives you've considered
None.

Additional context
https://support.google.com/docs/answer/65129

@juliusknorr
Copy link
Member

Other solutions have their own file format but when exporting to a regular office file, the mention is purely identified by the users email address. For the Nextcloud context we'd ideally have the user id or federated cloud id present as some kind of metadata, in order to uniquely identify the mentioned user. We are currently discussion with Collabora how we could store mentions in the comments in the actual file.

@juliusknorr
Copy link
Member

Findings so far, ODF does not seem to have any good fit for storing a unique user identifier (like the user id or federated cloud id) within the document, so while we could probably process mentions while being edited in COOL there is no good way we found until now to persist those properly. @kendy is still looking into options from the Collabora side.

@juliusknorr
Copy link
Member

@Raudius Noticed that we had this ticket for that and assigned you since we talked about that you would look into that.

@Raudius
Copy link
Contributor

Raudius commented Oct 20, 2022

@Raudius Noticed that we had this ticket for that and assigned you since we talked about that you would look into that.

Cool.

One thing to note is that with the current implementation this would only work in the document text (not in the comments). I recall that due to document format reasons getting it to work on comments is a lot more challenging.

@juliusknorr
Copy link
Member

Reopening for the remaining task:

  • Listen to the post message for inserted mention and emit a notifcation to the user

@juliusknorr juliusknorr reopened this Nov 18, 2022
@juliusknorr
Copy link
Member

Waiting for the Collabora build to finish the remaining bit of implementing a notification to the user.

@elhananjair
Copy link

Hello @juliushaertl, I recently discovered that I don't get notified when users I have shared comments on the file. It is a great feature to have for collaboration.
Is there any progress on this?

@marcoambrosini
Copy link
Member

@pedropintosilva we picked this for our next version and this would need some discussion in the next call.
@nextcloud/designers

@juliusknorr
Copy link
Member

@elzody Maybe you can align the next two weeks with Pedro on their roadmap about that and if we can involve our designers in this. Also need to clarify if we need anything else to be implemented from our side, additionally to #3960

@marcoambrosini
Copy link
Member

@elzody do you need any input from design on this?

@marcoambrosini marcoambrosini self-assigned this Sep 26, 2024
@juliusknorr
Copy link
Member

@Rash419 @pedropintosilva as far as I understood there is ongoing work on your side on mentioning in comments now, does it make sense to gather a bit of design/ux feedback from our designers in next weeks call?

@juliusknorr
Copy link
Member

CollaboraOnline/online#10145 was merged, let's give this some testing on our side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Waiting for a developer enhancement New feature or request upstream: collabora online
Projects
Status: 🏗️ In progress
Status: 🏗️ At engineering
Development

Successfully merging a pull request may close this issue.

6 participants