Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tool,nextcloud)!: Generate rich object parameters #1877

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

provokateurin
Copy link
Member

Closes #1847

Not really useful at the moment because of the lack of discriminator support (#1231) and a way to use exhaustive switch statements.

Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 50 lines in your changes missing coverage. Please review.

Project coverage is 30.92%. Comparing base (afc834f) to head (c624c39).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
+ Coverage   30.85%   30.92%   +0.07%     
==========================================
  Files         262      265       +3     
  Lines       96602    96709     +107     
==========================================
+ Hits        29808    29911     +103     
- Misses      66794    66798       +4     
Flag Coverage Δ *Carryforward flag
cookie_store 90.51% <ø> (ø) Carriedforward from 17bb8e1
dynamite 31.10% <ø> (ø) Carriedforward from 17bb8e1
dynamite_end_to_end_test 60.03% <ø> (ø) Carriedforward from 17bb8e1
dynamite_runtime 85.40% <ø> (ø) Carriedforward from 17bb8e1
neon_dashboard 96.20% <ø> (ø)
neon_framework 45.90% <ø> (+0.12%) ⬆️
neon_notifications 100.00% <ø> (ø)
neon_talk 98.66% <100.00%> (-0.29%) ⬇️
nextcloud 27.67% <20.63%> (-0.01%) ⬇️
sort_box 90.90% <ø> (ø) Carriedforward from 17bb8e1

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
...ckages/neon/neon_talk/lib/src/widgets/message.dart 98.54% <100.00%> (-1.04%) ⬇️
...on/neon_talk/lib/src/widgets/rich_object/file.dart 100.00% <100.00%> (ø)
...neon_talk/lib/src/widgets/rich_object/mention.dart 100.00% <100.00%> (ø)
packages/nextcloud/lib/src/api/spreed.openapi.dart 32.31% <80.00%> (-0.03%) ⬇️
...ckages/nextcloud/lib/src/api/spreed.openapi.g.dart 14.89% <15.51%> (-0.01%) ⬇️

... and 5 files with indirect coverage changes

@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from 4c998dc to 791d794 Compare April 6, 2024 21:51
@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from 791d794 to 66e488e Compare April 16, 2024 18:13
@provokateurin
Copy link
Member Author

I change the patch to only be a simple object instead of the discriminator so in theory it is usable now (and also everything works). I would like to first upstream the missing parameter type and missing fields. Additionally we have to wait until the next Talk releases which will include nextcloud/spreed#12021 as the some parameters were incorrectly not typed as string before.

@provokateurin
Copy link
Member Author

Ok apparently the fix for Talk was only backport to 29. To keep supporting the broken values we'll have to change the type to oneOf<int|string> for now :/ Once 28 support is dropped we can remove the hack.

@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from 66e488e to 2406cda Compare April 27, 2024 07:36
@provokateurin provokateurin changed the title feat(tool,nextcloud): Generate rich object parameters feat(tool,nextcloud)!: Generate rich object parameters Apr 27, 2024
@provokateurin
Copy link
Member Author

PR for the fields that are missing in the current definitions is sent upstream: nextcloud/server#45424

@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from 2406cda to be34dde Compare May 21, 2024 15:05
@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from be34dde to dd180e0 Compare July 14, 2024 18:22
@provokateurin provokateurin marked this pull request as ready for review July 14, 2024 18:22
@provokateurin
Copy link
Member Author

Let's just get this merged and using the discriminator can be done later once dynamite properly supports it again.

@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch 2 times, most recently from fe63baf to aa0fd2a Compare July 14, 2024 18:33
Copy link
Member

@Leptopoda Leptopoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please verify the comment.

packages/nextcloud/lib/src/api/spreed.openapi.json Outdated Show resolved Hide resolved
@provokateurin provokateurin force-pushed the feat/nextcloud/rich-object-parameters branch from aa0fd2a to c624c39 Compare July 17, 2024 06:28
@provokateurin provokateurin merged commit 4ced44c into main Jul 17, 2024
10 checks passed
@provokateurin provokateurin deleted the feat/nextcloud/rich-object-parameters branch July 17, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate rich object parameters from source code
2 participants