Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SieveAccountForm: improve styling and implement Nextcloud vue components #9898

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

GVodyanov
Copy link
Contributor

Fix #9894

Chromium:

A B
Screenshot from 2024-07-23 10-29-24 Screenshot from 2024-07-23 10-35-42

Firefox:

A B
image image

@GretaD
Copy link
Contributor

GretaD commented Jul 23, 2024

It looks nice but when we change the design, we should consult it with the design team as well

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me! Only 1 thing, the capitalization needs to be "Sentence case" everywhere as per design guidelines. E.g. "Sieve host" instead of "Sieve Host".

src/components/SieveAccountForm.vue Outdated Show resolved Hide resolved
src/components/SieveAccountForm.vue Outdated Show resolved Hide resolved
src/components/SieveAccountForm.vue Outdated Show resolved Hide resolved
@GVodyanov GVodyanov force-pushed the style/make-sieve-security-settings-pretty branch from 925b891 to 2bf1854 Compare July 23, 2024 14:28
@GVodyanov GVodyanov force-pushed the style/make-sieve-security-settings-pretty branch from 324e04b to 3297215 Compare July 23, 2024 14:39
@GVodyanov GVodyanov merged commit 53075e6 into main Jul 23, 2024
26 of 27 checks passed
@GVodyanov GVodyanov deleted the style/make-sieve-security-settings-pretty branch July 23, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sieve security buttons in account settings look bad
4 participants