Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sync): force full sync when the server reports QRESYNC #8968

Merged
merged 1 commit into from
Nov 30, 2023
Merged

fix(sync): force full sync when the server reports QRESYNC #8968

merged 1 commit into from
Nov 30, 2023

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Oct 17, 2023 •
edited
Loading

Fix #8223

Force a full sync by setting all three criteria if the server reports QRESYNC.

@st3iny st3iny self-assigned this Oct 17, 2023
@st3iny st3iny force-pushed the fix/sync/force-full-sync-on-qresync branch from cab46d2 to 624c826 Compare October 26, 2023 13:48
@st3iny
Copy link
Member Author

st3iny commented Oct 26, 2023

I moved the new logic one level higher to handle locking correctly. Otherwise, not all three sync tokens are locked.

@st3iny st3iny marked this pull request as ready for review October 26, 2023 13:56
@AlexanderZuehr

This comment was marked as resolved.

Sign in to view
@AlexanderZuehr AlexanderZuehr mentioned this pull request Nov 2, 2023
Open
@ChristophWurst

This comment was marked as resolved.

Sign in to view
@miaulalala miaulalala self-requested a review November 6, 2023 15:12
ChristophWurst
ChristophWurst approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync works also for an account without QRESYNC

This was referenced Nov 28, 2023
Open
Closed
@st3iny st3iny force-pushed the fix/sync/force-full-sync-on-qresync branch from 346560f to eacd84c Compare November 30, 2023 13:04
@st3iny st3iny added this to the v3.5.0 milestone Nov 30, 2023
@st3iny st3iny modified the milestones: v3.5.0, 3.6.0 Nov 30, 2023
@st3iny
Copy link
Member Author

st3iny commented Nov 30, 2023

/backport to stable3.5

@st3iny st3iny merged commit 768072a into main Nov 30, 2023
34 checks passed
@st3iny st3iny deleted the fix/sync/force-full-sync-on-qresync branch November 30, 2023 13:21
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 30, 2023
Merged
@ChristophWurst
Copy link
Member

/backport to stable3.4

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Nov 30, 2023
Merged
@szaimen
Copy link
Contributor

szaimen commented Nov 30, 2023

🎉🎉🎉🎉🎉

@st3iny st3iny mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JohannesGGE JohannesGGE Awaiting requested review from JohannesGGE

@miaulalala miaulalala Awaiting requested review from miaulalala

Assignees

@st3iny st3iny

Labels
4. to release bug
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Old mails deleted on other clients still show up as unread in Mail, when opened "Not found"
5 participants
@st3iny @AlexanderZuehr @ChristophWurst @szaimen @miaulalala