-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bring back needs info workflow #10293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Just some minor comments
only-labels: 'needs info' | ||
labels-to-remove-when-unstale: 'needs info,stale' | ||
exempt-issue-labels: '1. to develop,2. developing,3. to review,4. to release,discussion' | ||
days-before-stale: 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go higher or the action might tag too many tickets as stale in the next few days. Our issue tracker is still not fully triaged.
How about 90?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go higher or the action might tag too many tickets as stale in the next few days. Our issue tracker is still not fully triaged.
I think that's fine because the stale action will only comment on issues with the needs info label. Everything else is ignored.
.github/workflows/stale.yml
Outdated
Thanks again for your contributions – we really appreciate it! | ||
stale-issue-label: 'stale' | ||
only-labels: 'needs info' | ||
labels-to-remove-when-unstale: 'needs info,stale' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if the needs info label should be rmoved automatically or by the maintainer who asked for information? When something else is commented, or another person comments, the information is not always provided and the label would have to be added back manually.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you!
Signed-off-by: Daniel Kesselberg <[email protected]>
a5a8196
to
be9faf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't wait to see all the notifications on Monday
The action will not post or add labels for now, only print a list of issues in the action output.
I will check and change the repository variable then.