Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loading icon position #10272

Merged
merged 2 commits into from
Nov 12, 2024
Merged

fix: loading icon position #10272

merged 2 commits into from
Nov 12, 2024

Conversation

keremsemiz
Copy link
Contributor

@keremsemiz keremsemiz commented Oct 17, 2024 •
edited by ChristophWurst
Loading

Fixes #10258

@keremsemiz keremsemiz self-assigned this Oct 17, 2024
@welcome Welcome
Copy link

welcome bot commented Oct 17, 2024

Thanks for opening your first pull request in this repository! ✌️

@keremsemiz
Copy link
Contributor Author

Screenshot 2024-10-17 150855

@GretaD GretaD changed the title Loading Icon Position - #10258 fix: loading icon position Oct 17, 2024
ChristophWurst
ChristophWurst reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

src/components/Mailbox.vue Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@GretaD GretaD merged commit 12fad2d into main Nov 12, 2024
32 of 34 checks passed
@GretaD GretaD deleted the keremsemiz/issue10258 branch November 12, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@GretaD GretaD GretaD approved these changes

Assignees

@keremsemiz keremsemiz

Labels
3. to review feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Loading messages …" placed too low
3 participants
@keremsemiz @ChristophWurst @GretaD